Add repetition penalty warper #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add penalty to logits warpers * Test repetition penalty
pcuenca
reviewed
Apr 24, 2024
|
|
||
| public func warp(indices: [Int], logits: [Float]) -> (indices: [Int], logits: [Float]) { | ||
| var logits = logits | ||
| for index in indices { |
There was a problem hiding this comment.
Did you try to find an accelerated version of this? (not critical right now, but good to keep in mind for the future)
There was a problem hiding this comment.
I wanted to use gather scatter, but didn't find scatter method in vDSP.
| @@ -87,6 +87,36 @@ final class LogitsWarperTests: XCTestCase { | |||
| XCTAssertEqual(result5.logits, [2, 1, 0], accuracy: accuracy) | |||
| } | |||
|
|
|||
| func testRepetitionPenaltyWarper() { | |||
There was a problem hiding this comment.
Thanks for adding tests! Did you verify results against the reference transformers implementation?
pcuenca
reviewed
Apr 24, 2024
| public struct RepetitionPenaltyWarper: LogitsWarper { | ||
| public var penalty: Float | ||
|
|
||
| public init(penalty: Double) { |
There was a problem hiding this comment.
Maybe let's throw here if penalty <= 0 (it must be strictly positive)
|
Test runners are not working for some reason. I verified locally that the tests pass, so merging now. Thanks @shavit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84