Skip to content

Use injected HubApi for downloads instead of shared #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

petrukha-ivan
Copy link
Contributor

The current implementation of HubFileDownloader uses a shared instance of HubApi, which can lead to authorization errors when accessing private repositories due to a missing token. This PR updates the implementation to correctly respect and use the provided HubApi instance, ensuring proper authentication.

@petrukha-ivan petrukha-ivan marked this pull request as draft April 7, 2025 12:54
@petrukha-ivan petrukha-ivan marked this pull request as ready for review April 7, 2025 12:59
@FL33TW00D
Copy link
Collaborator

@petrukha-ivan great work! thank you for your contribution.

@FL33TW00D FL33TW00D merged commit ebee621 into huggingface:main Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants