Improve error handling and add error messages #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And now PRs are getting merged that are resulting in conflicts. This is why we urgently need automated formatting in this repo. |
DePasqualeOrg
force-pushed
the
add-error-messages
branch
3 times, most recently
from
6e5355d to
5594cf9
Compare
DePasqualeOrg
force-pushed
the
add-error-messages
branch
from
5594cf9 to
b0d4981
Compare
|
I resolved the conflicts from 1a926a2. It would be great if we could move forward with this before more conflicts happen. |
|
Sorry for the delay @DePasqualeOrg we've been busy with Gemma 3. @pcuenca let's see if we can get this in today/tomorrow :) |
|
90% sure there are no breaking changes here @davidkoski & @ZachNagengast but thought we'd tag to double check with you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've improved error handling and added descriptive error messages. As you can see from all the unnecessary diffs, the lack of automated formatting in this repo is making it very difficult for me to contribute. @pcuenca and @FL33TW00D, do you think you could decide on a formatting solution and merge that ASAP, ideally after this PR?