Better error handling through improved Display
and Error
impls
#616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This improves user-facing impls (primarily related to error reporting) such as
Display
andError
, in the following ways:Display
impls are provided when user-visible descriptions are needed, and{}
formatting is used instead of{:?
where appropriate.Debug
is not suitable for this purpose, as its output is neither human-readable nor stable nor reliable.Debug
formatting may very well print absolutely NOTHING at all, so it's basically completely unreliable, and that is on purpose. See e.g. debug-fmt-detail option rust-lang/rust#123940 for details.Error
impls are provided for all error-like types where missing, and thesource()
method is implemented in a more useful manner where possible, so as to provide error chaining/causality information..display()
method instead of Debug-formatting.Disp
type is simplified..to_string()
andformat!()
) are eliminated.The Python bindings are also updated according to these principles. The Python API is not affected.