Fix infinite recursion risk in ImageDataset error handling #2508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the error handling in ImageDataset.__getitem__ to prevent potential infinite recursion when loading corrupted or missing image files. The changes include: Added a maximum retry limit based on dataset size Improved error messages and logging Better separation of file access and image loading errors More robust error recovery with proper state management This makes the dataset loading more reliable and provides better diagnostics when issues occur.
### Changes - Added proper cleanup of tarfile objects to prevent file descriptor leaks - Improved error handling with more descriptive messages - Added worker safety for multi-process DataLoader scenarios - Enhanced file handling to read and close files immediately ### Impact - Prevents resource leaks during training with tar-based datasets - Makes error messages more actionable - Improves stability in multi-worker data loading - Maintains backward compatibility while being more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix infinite recursion risk in ImageDataset error handling
Changes
Impact