Skip to content

fix activation dtype #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix activation dtype #286

wants to merge 1 commit into from

Conversation

@sam-h-bean
Copy link
Contributor

What does this PR do?

Fix the activation type for quantizing for tensorrt

Fixes

ValueError: Invalid combination of use_static_quantization = False and activations_dtype = QuantType.QInt8. OnnxRuntime dynamic quantization requires activations_dtype = QuantType.QUInt8

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sam-h-bean sam-h-bean mentioned this pull request Jul 13, 2022
Closed
4 tasks
@sam-h-bean
Copy link
Contributor Author

@philschmid @JingyaHuang should we put this in? Feels like a bug

@philschmid philschmid requested a review from mfuntowicz July 14, 2022 08:07
@fxmarty fxmarty self-assigned this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfuntowicz mfuntowicz Awaiting requested review from mfuntowicz

Assignees

@fxmarty fxmarty

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sam-h-bean @HuggingFaceDocBuilderDev @fxmarty