only include tool_calls or tool_call_id in requests #3170
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
burtenshaw
changed the title
|
Hey @hanouticelina Do you want to merge this PR? |
| tool_call_id: Optional[str] = None | ||
| refusal: Optional[str] = None | ||
|
|
||
| def __post_init__(self) -> None: |
There was a problem hiding this comment.
does this mean it's broken for all providers currently? 😅
There was a problem hiding this comment.
I don't think it's broken for all providers, my intuition is that groq seems to be a bit more strict on this
There was a problem hiding this comment.
Yeah. I tested on other providers and it seems that groq is the only one to enforce.
|
@burtenshaw hey Ben, sorry for the late reply! let's wait for @Wauplin's feedback tomorrow and then we will merge and do a patch release as soon as possible. |
|
I'm suggesting a different solution in #3178. If you feel strongly about it, we can go with this one though. I just wanted to check if we could have a broader solution to avoid BadRequest errors because of some None values |
LGTM |
|
closing this as the issue is now solved in #3178 |
This PRs validate the chat completion requests to tools via inference providers use the correct schema.