[Bot] Update inference types #3104
Open
+107
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
7f293e7 to
8990983
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
===========================================
- Coverage 76.33% 57.12% -19.21%
===========================================
Files 130 134 +4
Lines 12952 13293 +341
===========================================
- Hits 9887 7594 -2293
- Misses 3065 5699 +2634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
3 times, most recently
from
7db22ba to
32628dd
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
3 times, most recently
from
47ec62d to
85374f2
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
3 times, most recently
from
53f15af to
ab506b6
Compare
|
Opened huggingface/huggingface.js#1537 and #3167 to finally fix the chat completion discrepancies. Once merged, we will get back to a "normal" PR with only text-to-video stuff. |
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
2 times, most recently
from
69e7ebd to
5a7d328
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
5a7d328 to
152ebf8
Compare
Wauplin
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Jun 25, 2025
In huggingface/huggingface_hub#3082 @hanouticelina fixed the Python inference types for chat completion grammar input. Biggest update was: ```py @dataclass_with_extra class ChatCompletionInputResponseFormatText(BaseInferenceType): type: Literal["text"] @dataclass_with_extra class ChatCompletionInputResponseFormatJSONSchema(BaseInferenceType): type: Literal["json_schema"] json_schema: ChatCompletionInputJSONSchema @dataclass_with_extra class ChatCompletionInputResponseFormatJSONObject(BaseInferenceType): type: Literal["json_object"] ChatCompletionInputGrammarType = Union[ ChatCompletionInputResponseFormatText, ChatCompletionInputResponseFormatJSONSchema, ChatCompletionInputResponseFormatJSONObject, ] ``` --- This PR reflects "officially" this update in the JS specs. It makes JS and Python specs aligned again (was not the case for the last month, ending up with annoying PRs like this one huggingface/huggingface_hub#3104). The result is not as satisfying as what a manual implementation would give because the 3 objects are merged in 1 with optional fields (see `export type ChatCompletionInputGrammarTypeType = "text" | "json_schema" | "json_object";`). This is because quicktype do not handle properly unions (see glideapps/quicktype#1266 - 6 yo :confused: ). It's not the only case like this in our specs but first time I find out about it. Not a problem since we don't enforce data structures. In Python, the data structure will result in this: huggingface/huggingface_hub#3167
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
3 times, most recently
from
8b59498 to
7da279c
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
4 times, most recently
from
46de283 to
9212cb7
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
2 times, most recently
from
870f0c6 to
53be813
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
3 times, most recently
from
001d86d to
6c3e0d7
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
6c3e0d7 to
a899310
Compare
|
waiting for #3231 to be merged first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the inference types. It has been generated by running:
This PR was automatically created by the Update Inference Types workflow.
Make sure the changes are correct before merging.