Skip to content

Add Use this model snippets for top diffusers models #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025

Conversation

apolinario
Copy link
Contributor

@apolinario apolinario marked this pull request as draft July 18, 2025 12:49
@@ -449,6 +726,8 @@ export const diffusers = (model: ModelData): string[] => {
}
} else if (model.tags.includes("textual_inversion")) {
return diffusers_textual_inversion(model);
} else if (model.tags.includes("FluxFillPipeline")) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example that doesn't need extra libraries to install

model.tags.includes("StableDiffusionInpaintPipeline") ||
model.tags.includes("StableDiffusionXLInpaintPipeline")
) {
return diffusers_inpainting(model);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example that doesn't need extra libraries to install

@apolinario
Copy link
Contributor Author

Still a draft as we are unsure whether the super custom ones (all of those that need the installation of a custom library) should stay in the PR or not

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe let's split this into two:

diffusers only first and the rest (3d model) seperate or can be a follow-up

@apolinario
Copy link
Contributor Author

Sounds good. Do you think we should keep the ones that do use diffusers but require extra libraries to function?

@apolinario
Copy link
Contributor Author

For now let's merge this with the simplest: just added to the ones that don't require installing any auxiliary libraries for now

@apolinario apolinario marked this pull request as ready for review July 18, 2025 14:39
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with the diffusers snippets, let's remove the Hunyuan3D snippet from this PR and we can do that in a follow-up too.

cc: @Wauplin if you have any strong feelings about the diffusers snippets.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving diffusers snippets, LGTM :) (only from high-level perspective, I trust you on the details)

@apolinario apolinario merged commit 04a3d77 into main Jul 21, 2025
5 checks passed
@apolinario apolinario deleted the fix-top-media-models branch July 21, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants