fix(qwenimage): Add padding for context parallelism #12595
+70
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug that causes the QwenImage model to crash when using context parallelism with a prompt whose sequence length is not divisible by the world size.
The fix is implemented within the QwenImageTransformer2DModel and consists of three parts:
start of the forward method to ensure their length is divisible by the world size.
embeddings (RoPE), preventing a tensor shape mismatch that was causing a RuntimeError.
A new unit test is also added to simulate a distributed environment. It verifies that the padding logic prevents the crash while ensuring the output is numerically equivalent to the baseline, non-padded run.
Fixes #12568
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul @yiyixuxu @DN6