[Modular] Some clean up for Modular tests #12579
Open
+269
−199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some changes to make modular tests more in line with our new testing approach
unittestdependencyget_pipelineto ModularPipelineTesterMixin (it's most likely going to be the same across all pipelines)unittestanymore, we need to be explicit about which objects are Mixins and which objects are actually running the tests and need attributes such asparam,repoetc.cpubased Generator through theself.get_generatormethod inModularPipelineTesterMixinfor better reproducibility (GPU based generator can introduce noise)torch.abs().maxfor comparing slices. Let's move away fromnpconversions. There isn't much of an advantage and when we run on GPU we can avoid.detach().cpu().numpy()callsFixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.