Skip to content

Adds FiftyOne Art Analysis Recipe to Cookbook #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

jacobmarks
Copy link
Contributor

This PR demonstrates how you can use a combination of traditional image processing, multimodal embeddings, unsupervised learning, and visualization to bring structure to unstructured visual data. The notebook illustrates these concepts in the context of art, using the WikiArt dataset from the Hugging Face Hub.

Fixes # (issue)

Who can review?

Feel free to tag members/contributors who may be interested in your PR.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -29,6 +29,8 @@

- title: Multimodal Recipes
sections:
- local: analyzing_art_with_hf_and_fiftyone
title: Analyzing Artistic Styles with 🤗 Transformers, 🤗 Hub, and FiftyOne
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if you could express something around the modality here, e.g. Analyzing Artworks using Multimodal Embeddings
I'd like @stevhliu to leave an opinion as well

@@ -0,0 +1,851 @@
{
Copy link
Collaborator

@merveenoyan merveenoyan May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this on top IMO


Reply via ReviewNB

@@ -0,0 +1,851 @@
{
Copy link
Collaborator

@merveenoyan merveenoyan May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think multimodal is a very broad term here, the word you're looking for is image-text encoder models IMO (SigLIP, EvaCLIP etc) you could say CLIP-like models


Reply via ReviewNB

@@ -0,0 +1,851 @@
{
Copy link
Collaborator

@merveenoyan merveenoyan May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give single link to overall integrations page not to break readability or add that at the end in something like useful resources


Reply via ReviewNB

@@ -0,0 +1,851 @@
{
Copy link
Collaborator

@merveenoyan merveenoyan May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can give this at the end to useful resources


Reply via ReviewNB

@@ -0,0 +1,851 @@
{
Copy link
Collaborator

@merveenoyan merveenoyan May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a "." at the end


Reply via ReviewNB

@merveenoyan
Copy link
Collaborator

fiftyone seems to be a very cool app @jacobmarks, thanks a lot for contributing this 🤗

@jacobmarks jacobmarks requested a review from merveenoyan May 7, 2024 13:26
@jacobmarks
Copy link
Contributor Author

Thanks for the review @merveenoyan ! I've made the requested changes :) Let me know what else I can do. Grateful for your guidance.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@@ -0,0 +1,838 @@
{
Copy link
Member

@stevhliu stevhliu May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here (italicized so you can see it easier) :)

"This will allow us to see how the images cluster based on their style, genre, and artist."


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really fun and informative recipe, great job! 👏

@jacobmarks
Copy link
Contributor Author

Really fun and informative recipe, great job! 👏

Thanks @stevhliu, really appreciate it :)

@merveenoyan merveenoyan merged commit e7f1de0 into huggingface:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants