-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Assistant] Delete avatar button instead of reset #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nsarrazin
merged 12 commits into
feature/assistants
from
feature/delete_instead_of_reset
Jan 24, 2024
Merged
[Assistant] Delete avatar button instead of reset #725
nsarrazin
merged 12 commits into
feature/assistants
from
feature/delete_instead_of_reset
Jan 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary149
approved these changes
Jan 24, 2024
nsarrazin
added a commit
that referenced
this pull request
Jan 24, 2024
* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <mikelfried@gmail.com> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <mikelfried@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <victor.mustar@gmail.com> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Victor Mustar <victor.mustar@gmail.com> Co-authored-by: Michael Fried <mikelfried@gmail.com>
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (huggingface#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (huggingface#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <mikelfried@gmail.com> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <mikelfried@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (huggingface#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <victor.mustar@gmail.com> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Victor Mustar <victor.mustar@gmail.com> Co-authored-by: Michael Fried <mikelfried@gmail.com>
maksym-work
pushed a commit
to siilats/chat-ui
that referenced
this pull request
Jul 2, 2025
* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (huggingface#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (huggingface#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <mikelfried@gmail.com> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <mikelfried@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (huggingface#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <victor.mustar@gmail.com> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Victor Mustar <victor.mustar@gmail.com> Co-authored-by: Michael Fried <mikelfried@gmail.com>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (huggingface#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (huggingface#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <mikelfried@gmail.com> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <mikelfried@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (huggingface#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <victor.mustar@gmail.com> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Victor Mustar <victor.mustar@gmail.com> Co-authored-by: Michael Fried <mikelfried@gmail.com>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (huggingface#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (huggingface#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <mikelfried@gmail.com> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <mikelfried@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (huggingface#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <victor.mustar@gmail.com> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Victor Mustar <victor.mustar@gmail.com> Co-authored-by: Michael Fried <mikelfried@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "reset" behaviour to a "delete" behaviour