Minor Fixes #37
Closed
Minor Fixes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mose
reviewed
Jul 13, 2017
There was a problem hiding this comment.
Sorry but the use of the @ is specific to the slack context (probably rocketchat too) but on irc and many others, it's not the usualy way.
Maybe you can add a test on the adapter (erk) but best would be to introduce a new method in adapters something like robotName.displayname. But then it needs a PR on the slack adapter, plus another one on core hubot code... man my head hurts :D
|
Yikes! I had no idea it would be so involved! Thanks for walking me through it, I'll have to sleep on it to decide if I want to invest the time for this or not. |
|
Okay let's close this one for now, your other PR #38 covers the other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a typo in the comments, added the "@" prefix to the robot name to make the help text more intuitive.