-
Notifications
You must be signed in to change notification settings - Fork 1
Update Kotlin to 2.2.0-RC2, Compose to v1.8.1, the Gradle wrapper to v8.14.2, and AGP to v8.10.1 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
------------------ buildSrc kotlinVersion -> 2.2.0-RC2 compose-gradle-plugin -> 1.8.1 -------------------- ------------------ demo Copy -> Sync val jsBrowserDistribution by tasks.getting(Sync::class) val wasmJsBrowserDistribution by tasks.getting(Sync::class) -------------------- ------------------ material-icons-core comment the material-icons-extended dependencies --------------------
``` Cannot inline bytecode built with JVM target 11 into bytecode that is being built with JVM target 1.8. Specify proper '-jvm-target' option. ```
…ended` The version is fixed at 1.7.3.
Please check if #58 is resolved by this. |
``` :compose-multiplatform-html-unified-material2 is not configured for JS usage ``` A related warning should also have been resolved: ``` w:⚠️ JS Environment Not Selected ```
…rsion=8.14.2 && ./gradlew wrapper`
As told by @waste-of-kindergarten, the build works with neither JDK 11 nor JDK 17 in IntelliJ IDEA. See https://developer.android.com/build/releases/gradle-plugin#compatibility.
Potential errors like this should be resolved: ``` e: file:///home/runner/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/2.2.0-RC2/87c573e16fe0194e3dba3f890597bb372c2b83f6/kotlin-stdlib-2.2.0-RC2.jar!/META-INF/kotlin-stdlib-jdk7.kotlin_module Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.2.0, expected version is 2.0.0. ```
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades core project tooling and dependencies to align with recent releases and RC versions.
- Bumps Kotlin to 2.2.0-RC2, Compose plugin to 1.8.1, AGP to 8.10.1, and Gradle wrapper to 8.14.2
- Regenerates unified API files to reflect new Kotlin compiler output (lambda symbol changes)
- Updates build scripts, task types, and CI matrix to match new toolchain requirements
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
material2/api/jvm/compose-multiplatform-html-unified-material2.api | Renamed autogenerated lambda getters to new hash-based names |
material2/api/android/compose-multiplatform-html-unified-material2.api | Same lambda renaming for Android API |
material-icons-core/build.gradle.kts | Switched material-icons-extended version property reference |
gradlew.bat | Cleared CLASSPATH and added -jar invocation for wrapper JAR |
gradlew | Simplified APP_HOME print, cleared CLASSPATH quoting, added -jar mode |
gradle/wrapper/gradle-wrapper.properties | Updated distribution URL to Gradle 8.14.2 |
demo/build.gradle.kts | Changed task retrieval from Copy to Sync |
common/api/jvm/compose-multiplatform-html-unified-common.api | Updated interface methods from abstract fun to concrete fun |
common/api/android/compose-multiplatform-html-unified-common.api | Same interface method signature updates for Android |
buildSrc/src/main/kotlin/common-conventions.gradle.kts | Bumped JVM toolchain to 17; added browser targets for JS/WASM |
buildSrc/src/main/kotlin/VersionsAndDependencies.kt | Introduced new composeMultiplatformMaterialIconsExtended constant |
buildSrc/src/main/kotlin/Android.kt | Incremented androidSdkVersion to 35 |
buildSrc/build.gradle.kts | Updated Kotlin, Compose Gradle, and AGP plugin versions |
.github/workflows/ci.yml | Removed Java 8 from CI JDK matrix |
Comments suppressed due to low confidence (3)
buildSrc/src/main/kotlin/common-conventions.gradle.kts:22
- [nitpick] This TODO is ambiguous; consider removing it or implementing the
jvm("desktop")
configuration if needed to avoid confusion.
jvm() // TODO: `jvm("desktop")`?
buildSrc/src/main/kotlin/common-conventions.gradle.kts:41
- [nitpick] This comment is vague; specify which potential issues this configuration addresses or link to relevant docs/issues for clarity.
// The project works without this, but it can be added to avoid potential issues.
.github/workflows/ci.yml:22
- [nitpick] Removing Java 8 from the CI matrix reduces coverage on older JDKs; if Java 8 compatibility is still required, consider retaining it in tests.
jdk-versions: 17-temurin
No description provided.