Fix the order of LIMIT and OFFSET clauses when using the Presto flavor (issue #195) #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r (issue #195) Queries that have both a limit and an offset build a query with a limit clause *before* the offset clause. ```go fmt.Println(Select("*").From("table").Offset(5).Limit(10)) // SELECT * FROM table LIMIT 10 OFFSET 5 ``` This seems to generate syntax errors in Trino. [Presto documentation specifies OFFSET before LIMIT](https://prestodb.io/docs/current/sql/select.html#limit-clause) in the SELECT statement documentation too, but is not very explicit about the reverse not being supported. If the OFFSET and LIMIT clauses are swapped, the query succeeds. Expected: ```go fmt.Println(Select("*").From("table").Offset(5).Limit(10)) // SELECT * FROM table OFFSET 5 LIMIT 10 ```
|
LGTM. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #195:
Queries that have both a limit and an offset build a query with a limit clause before the offset clause.
This seems to generate syntax errors in Trino. Presto documentation specifies OFFSET before LIMIT in the SELECT statement documentation too, but is not very explicit about the reverse not being supported.
If the OFFSET and LIMIT clauses are swapped, the query succeeds.
Expected: