Skip to content

Remove serverHeader #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/core/aliases.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"handleError": [ "handleError", "handleerror" ],
"cors": [ "cors", "CORS" ],
"headers": [ "H", "header", "headers" ],
"serverHeader": [ "serverHeader", "serverheader", "server-header" ],
"contentType": [ "contentType", "contenttype", "content-type" ],
"mimeType": [
"mimetype",
Expand Down
1 change: 0 additions & 1 deletion lib/core/defaults.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"brotli": false,
"defaultExt": ".html",
"handleError": true,
"serverHeader": true,
"contentType": "application/octet-stream",
"weakEtags": true,
"weakCompare": true,
Expand Down
6 changes: 0 additions & 6 deletions lib/core/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ module.exports = function createMiddleware(_dir, _options) {
let defaultExt = opts.defaultExt;
const handleError = opts.handleError;
const headers = opts.headers;
const serverHeader = opts.serverHeader;
const weakEtags = opts.weakEtags;
const handleOptionsMethod = opts.handleOptionsMethod;

Expand Down Expand Up @@ -196,11 +195,6 @@ module.exports = function createMiddleware(_dir, _options) {
gzippedFile = `${file}.gz`;
brotliFile = `${file}.br`;

if (serverHeader !== false) {
// Set common headers.
res.setHeader('server', `http-server-${version}`);
}

Object.keys(headers).forEach((key) => {
res.setHeader(key, headers[key]);
});
Expand Down
10 changes: 0 additions & 10 deletions lib/core/opts.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module.exports = (opts) => {
let defaultExt = defaults.defaultExt;
let handleError = defaults.handleError;
const headers = {};
let serverHeader = defaults.serverHeader;
let contentType = defaults.contentType;
let mimeTypes;
let weakEtags = defaults.weakEtags;
Expand Down Expand Up @@ -140,14 +139,6 @@ module.exports = (opts) => {
}
});

aliases.serverHeader.some((k) => {
if (isDeclared(k)) {
serverHeader = opts[k];
return true;
}
return false;
});

aliases.contentType.some((k) => {
if (isDeclared(k)) {
contentType = opts[k];
Expand Down Expand Up @@ -203,7 +194,6 @@ module.exports = (opts) => {
brotli,
handleError,
headers,
serverHeader,
contentType,
mimeTypes,
weakEtags,
Expand Down
40 changes: 0 additions & 40 deletions test/server-header.test.js

This file was deleted.