Skip to content

test on Windows in Travis CI #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Conversation

Xmader
Copy link
Contributor

@Xmader Xmader commented Nov 9, 2019

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

ensure #569 continue to work on Windows

What changes did you make?

test on Windows in Travis CI

@Xmader
Copy link
Contributor Author

Xmader commented Nov 9, 2019

Once #569 is merged, tests should pass, like https://travis-ci.com/Xmader/http-server/builds/135804596.

Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! I don't know about the other maintainers, but I, personally, have no way to test on Windows, so it's good to have testing for it!

I'll wait to merge until we get master back into this pr to get tests passing

@thornjad thornjad added this to the v0.12.0 milestone Nov 10, 2019
@thornjad thornjad merged commit a306ebc into http-party:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants