fix issue #402 by documenting magic command to generate a SSL certifi… #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SL certificate
|
Credit to @krzkaczor for actually providing the command! |
thornjad
approved these changes
Sep 20, 2019
|
Thx!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cate
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Fixes #402 documenting the magic command to generate a self signed ssl certificate. This worked great for me, and other ones I saw online didn't work with http-server.
What changes did you make?
Documentaiton fix
Provide some example code that this change will affect, if applicable:
Is there anything you'd like reviewers to focus on?
Please provide testing instructions, if applicable:
Run the command, then use it via http-server ../files --cors --ssl --cert ./cert.pem --key ./key.pem -p 8443 and make sure it works!