Skip to content

add option for client IP logging #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2019
Merged

add option for client IP logging #501

merged 2 commits into from
Apr 15, 2019

Conversation

thornjad
Copy link
Member

@thornjad thornjad commented Feb 4, 2019

Continuing work by @paked in #187, this adds the useful feature of
logging the remote client IP address. I personally use this feature in
Apache often at work, and it would be nice to have it here as well!

The addition is the --log-ip option, which adds the client IP to the
log message between the date and the request method and url.

Fixes #184

Continuing work by @paked in #187, this adds the useful feature of
logging the remote client IP address. I personally use this feature in
Apache often at work, and it would be nice to have it here as well!

The addition is the `--log-ip` option, which adds the client IP to the
log message between the date and the request method and url.

Signed-off-by: Jade Thornton <jade@jmthornton.net>
Signed-off-by: Jade Thornton <jade@jmthornton.net>
@BigBlueHat BigBlueHat self-requested a review February 27, 2019 19:43
Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thornjad thornjad added this to the v0.12.0 milestone Feb 28, 2019
@thornjad thornjad merged commit bfee8d4 into master Apr 15, 2019
thornjad added a commit that referenced this pull request Apr 15, 2019
add option for client IP logging
@thornjad thornjad deleted the log-client-ip branch April 15, 2019 14:43
@cyqsimon cyqsimon mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get clients IPs? How?
2 participants