Skip to content

Enable customizable cache time #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable customizable cache time #404

wants to merge 1 commit into from

Conversation

houston3
Copy link

@houston3 houston3 commented Oct 23, 2017 •
edited by thornjad
Loading

Ecstatic supports passing a function as a cache argument, but http-server passes the argument as a string. Added eval to make the function work. Also updated tests.

Fixes #63

@houston3 houston3 mentioned this pull request Oct 23, 2017
Closed
thornjad
thornjad requested changes Feb 28, 2019
View reviewed changes
@houston3
Copy link
Author

houston3 commented Mar 2, 2019

Added support for string args.

@thornjad thornjad self-requested a review April 22, 2019 15:03
@peschee
Copy link

peschee commented Oct 1, 2019

Are there any updates on this? Is something missing in order to merge this?

@thornjad thornjad added this to the v0.13.0 milestone Dec 11, 2019
@thornjad thornjad added the minor version non-breaking, non-trivial change label Dec 18, 2019
thornjad
thornjad requested changes Dec 21, 2019
View reviewed changes
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of passing a function like this through the CLI. Would it be reasonable to accept a JS filename to execute, or at least encourage the user to use require?

@thornjad
Copy link
Member

You'll need to merge or rebase master, your branch doesnt run tests on Node 12 or 13 due to an outdated package.json loading in an old version of vows

@houston3
Enabled customizable cache time. Ecstatic supports passing a function as
0d7ef40 
a cache argument. Added logic to support inline and imported cache
functions. Fixes (http-party#63)
@houston3 houston3 requested a review from thornjad January 26, 2020 20:39
@thornjad
Copy link
Member

Closing as out-of-scope, see #63 (comment)

@thornjad thornjad closed this Jul 13, 2021
@thornjad thornjad added out-of-scope Not part of the purpose and/or responsibility of this project and removed minor version non-breaking, non-trivial change labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornjad thornjad Awaiting requested review from thornjad

Assignees
No one assigned
Labels
out-of-scope Not part of the purpose and/or responsibility of this project
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

allow different cache times for different urls
3 participants
@houston3 @peschee @thornjad