Skip to content

fixbug with -o [path] Open browser window after starting the server #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2019

Conversation

sqlwwx
Copy link
Contributor

@sqlwwx sqlwwx commented Feb 26, 2016

fixbug with -o [path] Open browser window after starting the server

@andywer
Copy link

andywer commented Mar 15, 2016

+1
Tested it locally and works for me, too, now (Chrome 49 on OSX). Would appreciate it if it could be merged soon :)

@craigmichaelmartin
Copy link

I think squashing your commits would help :) Also, is this a duplicate of #234?

craigmichaelmartin added a commit to craigmichaelmartin/http-server that referenced this pull request Apr 6, 2016
@derhuerst derhuerst mentioned this pull request Sep 14, 2016
@thornjad
Copy link
Member

thornjad commented Feb 5, 2019

Redundant '//' fixed in #374

@thornjad thornjad closed this Feb 5, 2019
@thornjad
Copy link
Member

thornjad commented Feb 5, 2019

Sorry, closed the wrong PR

@thornjad
Copy link
Member

thornjad commented Feb 5, 2019

@sqlwwx would you rebase this onto the current master? Otherwise I can take this over if you'd like.

@sqlwwx
Copy link
Contributor Author

sqlwwx commented Feb 11, 2019

@thornjad updated

@thornjad thornjad self-requested a review February 28, 2019 14:24
@thornjad thornjad added this to the v0.12.0 milestone Feb 28, 2019
@thornjad thornjad merged commit 004da3b into http-party:master Apr 15, 2019
thornjad added a commit that referenced this pull request Apr 15, 2019
fixbug with -o [path] Open browser window after starting the server
@pjm4
Copy link

pjm4 commented Aug 30, 2019

This doesn't appear to be in the latest release: http-server@0.11.1 - would be nice to get this fix released. FYI - running on a Mac 'http-server -o folder' just starts the server, but no browser is launched. If 'folder' is omitted the browser launches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants