Skip to content

Add -u option to open browser with custom url #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hugomn
Copy link

@hugomn hugomn commented Aug 7, 2015

In some cases you have a aliased domain for your localhost (e.g: local.mydomain.com) it's necessary you open the browser after running the http-server pointing to that domain.

@indexzero
Copy link
Member

Could you also update the README.md?

@hugomn
Copy link
Author

hugomn commented Aug 10, 2015

Done! =)

In some cases you have a aliased domain for your localhost (e.g: local.mydomain.com) it's necessary you open the browser after running the http-server pointing to that domain
@hugomn
Copy link
Author

hugomn commented Apr 20, 2016

Any news on this?

@BigBlueHat BigBlueHat added this to the v0.10.0 milestone Apr 25, 2017
@BigBlueHat
Copy link
Member

This seems useful, but we may need to change the parameter from -u to --url after some of the other things like #245 get addressed--to be sure we're not going to make things too confusing parameter-wise. It's queued for v0.10.0 though.

@BigBlueHat BigBlueHat modified the milestones: v0.10.0, v0.11.0 Apr 25, 2017
@BigBlueHat BigBlueHat modified the milestones: v0.11.0, v0.12.0 Jan 10, 2018
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of merge conflicts, could you take a look at those? Thank you for your PR!

`-o` Open browser window after staring the server
`-o` Open browser window after starting the server

`-u` Url to display in the opened browser (in case you have an alias to your localhost)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we actually change this to --url to avoid confusion with --utc and --username?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not possible because -o doesn't let you specify the desired url to open. I'll check the conflicts (3 years after!).

@thornjad
Copy link
Member

Actually @hugomn, can this functionality be achieved with the -o option?

@thornjad
Copy link
Member

No, it's not possible

What about using -a? Like with the URL in your first comment, could you do this with -a local.mydomain.com -o /my/path?

(3 years after!)

Yeah I know, we're working on it :)

@thornjad thornjad modified the milestones: v0.12.0, v0.13.0 Nov 19, 2019
@thornjad
Copy link
Member

Closing due to inactivity, re-open if we'd still like to get this functionality. In my opinion, this would be better added as part of -o rather than as its own option.

@thornjad thornjad closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants