-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add -u option to open browser with custom url #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you also update the README.md? |
Done! =) |
In some cases you have a aliased domain for your localhost (e.g: local.mydomain.com) it's necessary you open the browser after running the http-server pointing to that domain
Any news on this? |
This seems useful, but we may need to change the parameter from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of merge conflicts, could you take a look at those? Thank you for your PR!
`-o` Open browser window after staring the server | ||
`-o` Open browser window after starting the server | ||
|
||
`-u` Url to display in the opened browser (in case you have an alias to your localhost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we actually change this to --url
to avoid confusion with --utc
and --username
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not possible because -o
doesn't let you specify the desired url to open. I'll check the conflicts (3 years after!).
Actually @hugomn, can this functionality be achieved with the |
What about using
Yeah I know, we're working on it :) |
Closing due to inactivity, re-open if we'd still like to get this functionality. In my opinion, this would be better added as part of |
In some cases you have a aliased domain for your localhost (e.g: local.mydomain.com) it's necessary you open the browser after running the http-server pointing to that domain.