build: Ensure strchrnul() is available in header (fixes macOS build) #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you put the extra check into a darwin specific section and leave the rest as is for the 99.9%+ compiles on other platforms? |
The |
BenBE
added
enhancement
Explorer09
force-pushed
the
strchrnul-darwin
branch
from
7662f5b to
5eb1e6c
Compare
The strchrnul() function is also introduced in macOS 15.4, however, for macOS build, a compiler may default to building for an older macOS version (such as 15.0). The configure script can wrongly assume the function may be used. Fix the configure script's detection of strchrnul() by ensuring it's actually available through the header. Fixes: htop-dev#1659 Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Explorer09
force-pushed
the
strchrnul-darwin
branch
from
5eb1e6c to
0a57ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strchrnul() function is also introduced in macOS 15.4, however, for macOS build, a compiler may default to building for an older macOS version (such as 15.0). The configure script can wrongly assume the function may be used.
Fix the configure script's detection of strchrnul() by ensuring it's actually available through the header.
Fixes: #1659