Skip to content

HPCC-34819 Reworked Update #20577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

HPCC-34819 Reworked Update #20577

wants to merge 2 commits into from

Conversation

@asselitx
Copy link
Contributor

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Panagiotatos and others added 2 commits October 21, 2025 10:46
HPCC-34819 Document SSL/TLS setup for Containerized ESPs
a8d26cd 
Signed-off-by: Panagiotatos <greg.panagiotatos+copilot@lexisnexisrisk.com>
@asselitx
HPCC-34819 TLS Config Documentation Update
421317d 
Significant change from the Copilot-driven original, removing examples that
didn't best capture the platform supported features and included examples
of Helm template output rather than values.yaml configuration.

- Restructured to focus on the three best-supported TLS configuration
  scenarios.
- Includes much material from helm/examples and references some files
  in that location for CLI steps in examples.
- Moved the 'rebased' Certificates section to be a child under the Security
  Values section.
- Even though they were maybe out of scope for the ticket, kept the Secrets
  Vault and CORS sections. Made mimimal changes to improve the readability
  and helpfulness, but didn't give the overhaul they likely need.

This proposed update will likely need changes for tone, style and readability.

Signed-off-by: Terrence Asselin <terrence.asselin+copilot@lexisnexisrisk.com>
Copilot AI review requested due to automatic review settings October 28, 2025 22:05
@asselitx asselitx marked this pull request as draft October 28, 2025 22:06
@asselitx asselitx mentioned this pull request Oct 28, 2025
Open
39 tasks
Copilot AI reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34819

Jirabot Action Result:
Changing assignee from: greg.panagiotatos@lexisnexisrisk.com to: terrence.asselin@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Additional PR: #20577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asselitx