Fixed : added specific headers (#397)

[Nirvan-Bobde30]

Related Issues

hotwax/dxp-components#397

Short Description and Why It's Useful

• added specific headers in firebase.json

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @Nirvan-Bobde30, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on bolstering the application's security by implementing a series of updates to its HTTP security headers within the firebase.json configuration. The changes aim to mitigate risks such as cross-site scripting (XSS), clickjacking, and MIME-sniffing, ensuring a more secure browsing experience for users.

Highlights

• Security Header Updates: The firebase.json configuration has been updated to modify several HTTP security headers, enhancing the application's defense against common web vulnerabilities.
• Content-Security-Policy (CSP) Refinement: The CSP has been adjusted to allow scripts from Firebase applications (*.firebaseapp.com), restrict connect-src to 'self', and explicitly permit framing from Shopify admin domains (https://admin.shopify.com, https://*.myshopify.com). The X-Frame-Options header was removed as its functionality is now covered by the frame-ancestors directive in CSP.
• Strict-Transport-Security (HSTS) Enhancement: The HSTS policy has been strengthened by including the preload directive, which encourages browsers to remember the HSTS policy for the domain even before the first visit.
• X-Content-Type-Options Added: A new X-Content-Type-Options header with the value NoSniff has been added to prevent browsers from MIME-sniffing a response away from the declared content-type.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances security by updating HTTP headers in firebase.json. It strengthens the Content Security Policy, adds preload to Strict-Transport-Security, and includes the X-Content-Type-Options header. However, I've found a critical syntax error in the updated Content-Security-Policy value that is present for all environments (prod, dev, uat). This error will likely cause browsers to ignore the policy, so it needs to be fixed.

[gemini-code-assist]

The Content-Security-Policy value has a syntax error. The trailing * is not part of a valid directive and will likely cause browsers to ignore the entire policy, negating its security benefits. Please remove the trailing ; *.

Suggested change

	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com; *"
	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com"

[gemini-code-assist]

Similar to the prod configuration, the Content-Security-Policy value here has a syntax error. The trailing * is not a valid directive and should be removed to ensure the policy is enforced by browsers.

Suggested change

	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com; *"
	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com"

[gemini-code-assist]

This Content-Security-Policy value also contains the same syntax error as the prod and dev configurations. Please remove the invalid trailing * to fix the policy.

Suggested change

	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com; *"
	"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com *.firebaseapp.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self'; frame-ancestors https://admin.shopify.com https://*.myshopify.com"