Skip to content

Ensure split pane uses lg breakpoint #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Ensure split pane uses lg breakpoint #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<template>
<ion-app v-if="showMenu">
<IonSplitPane content-id="main-content" when="lg">
<ion-split-pane when="lg" content-id="main-content">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the change to kebab-case for the component name is great for consistency, the attribute order could be improved for better readability by following the recommended Vue style guide conventions. Attributes that provide global awareness, like content-id, are typically placed before other attributes. 1

<ion-split-pane content-id="main-content" when="lg">

Style Guide References

Footnotes

  1. The official Vue Style Guide recommends an order for attributes where 'Global Awareness' attributes (like id) come before other attributes. content-id functions similarly to an id and should be placed before the when prop. ↩

<Menu />
<ion-router-outlet id="main-content"></ion-router-outlet>
</IonSplitPane>
</ion-split-pane>
</ion-app>
<ion-app v-else>
<ion-router-outlet id="main-content"></ion-router-outlet>
Expand Down
Loading