Improved: hidding open tab in completed-detail pg after last shipment(#1286)

[SuyashSingh01]

Related Issues

#1286

Short Description and Why It's Useful

Fixed: fixes in case of one open item shipment in completed detail page hidding the tabs when changing navigation url.

Screenshots of Visual Changes before/after (If There Are Any)

Jam Reference: https://jam.dev/c/ac07aeb3-e577-4a57-bfd2-7c55e6486fdb

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @SuyashSingh01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a UI inconsistency where tabs would disappear on the completed detail page after processing the last shipment. The core of the fix involves enhancing the application's routing mechanism to consistently carry the 'category' context through navigation flows, particularly when moving between shipment review and order detail pages. This ensures that the user interface maintains its expected state and tab visibility after critical actions.

Highlights

• Route Parameter Addition: A new :category parameter has been added to the /transfer-shipment-review/:shipmentId route, allowing for better context passing during navigation.
• Navigation Context Preservation: The navigation logic has been updated in TransferOrderDetail.vue and TransferShipmentReview.vue to pass and utilize the category parameter, ensuring that the correct tab context is maintained across different views.
• Bug Fix for Tab Visibility: This change specifically addresses an issue where tabs were incorrectly hidden on the completed detail page after the last shipment, by ensuring the navigation URL retains the necessary category information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where the selected tab ('open' or 'completed') was not preserved when navigating between the transfer order detail page and the shipment review page. The fix involves adding a category parameter to the TransferShipmentReview route and passing this parameter during navigation. The changes are logical and correctly solve the described problem. I've added one suggestion to improve code maintainability by using a named route for navigation, which is a more robust approach than using hardcoded URL paths.

[gemini-code-assist]

For better maintainability and to avoid hardcoding URL paths, it's recommended to use named routes for navigation. This makes the code more resilient to future changes in the URL structure.

        this.router.replace({ name: 'TransferOrderDetail', params: { orderId: this.currentShipment.orderId, category: this.route.params.category } })