-
Notifications
You must be signed in to change notification settings - Fork 62
#1381/error fixed now the text is no longer getting hidden and is shown in one single line as intended #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nt text is not getting hidden anymore
Summary of ChangesHello @ShubhPaliwal11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user interface issue on the Create Transfer Order page where the 'Complete order on fulfillment' toggle label was not fully visible due to text wrapping and insufficient container width. The changes involve restructuring the toggle component, adjusting the layout's minimum width, and applying specific CSS to ensure the label is always clearly displayed on a single line, thereby enhancing the user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for this contribution. The fix correctly addresses the UI issue where the toggle label was wrapping and getting hidden by restructuring the component and adjusting the layout. The changes are logical and effective. I've added a few minor suggestions to improve code cleanliness and remove redundancy. Please take a look at them.
| const {token, oms, omsRedirectionUrl} = payload; | ||
| dispatch("setUserInstanceUrl", oms); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <ion-icon :icon="checkmarkDoneOutline" slot="start"/> | ||
| <ion-label class="ion-no-wrap">{{ translate("Complete order on fulfillment") }}</ion-label> | ||
| <ion-toggle data-testid="toggle-complete-on-fulfillment" slot="end" :checked="currentOrder.statusFlowId === 'TO_Fulfill_Only'" @ionChange="toggleStatusFlow" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to follow standard code formatting, please indent these elements correctly within the <ion-item> tag.
<ion-icon :icon="checkmarkDoneOutline" slot="start"/>
<ion-label class="ion-no-wrap">{{ translate("Complete order on fulfillment") }}</ion-label>
<ion-toggle data-testid="toggle-complete-on-fulfillment" slot="end" :checked="currentOrder.statusFlowId === 'TO_Fulfill_Only'" @ionChange="toggleStatusFlow" />
| .complete-fulfillment-item ion-label { | ||
| white-space: nowrap !important; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related Issues
#1381
Short Description and Why It's Useful
Fixed the visibility issue of the "Complete order on fulfillment" toggle label on the Create Transfer Order page. The label text was wrapping into multiple lines and getting hidden due to insufficient container width.
Changes made:
ion-labelwithion-togglein separate elementswhite-space: nowrap)This ensures the toggle label is clearly visible and readable on a single line at all zoom levels, improving the user experience when creating transfer orders.
Screenshots of Visual Changes before/after (If There Are Any)
BEFORE:

AFTER:

Contribution and Currently Important Rules Acceptance