Improved:Replaced the ecomstore to productstore at app level(#375)

[SuyashSingh01]

Related Issues

Issue:dxp-component/375
Issue Link; hotwax/dxp-components#375

Improved:Replaced the Ecomstore to ProductStore at app level

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @SuyashSingh01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a comprehensive refactoring initiative to standardize the naming convention for store-related entities within the application. The primary change involves renaming all occurrences of 'eComStore' to 'productStore' to better reflect the domain concept and improve code readability and maintainability. This change impacts various components, Vuex store modules, and utility functions, ensuring a consistent nomenclature throughout the codebase.

Highlights

• Naming Convention Standardization: All instances of 'eComStore' have been systematically renamed to 'productStore' across the application to ensure consistent terminology and improve code clarity.
• Variable and Property Renaming: Variables, computed properties, and function parameters previously named 'currentEComStore' or 'eComStoreId' have been updated to 'currentProductStore' or 'productStoreId' respectively.
• Action Method Refactoring: The 'setEComStore' action in the user store has been renamed to 'setProductStore' to align with the new naming convention.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request undertakes a significant refactoring to rename eComStore to productStore across the application, which is a good step towards improving code clarity. The changes are extensive and mostly correct. My review highlights a few areas where the refactoring appears incomplete, leading to inconsistencies that could be confusing for future maintenance. These include using new variable names with old method names from dependencies, and mismatches between component prop/event names and their handlers. Addressing these points will help to fully align the codebase with the intended naming convention and improve overall maintainability.

[gemini-code-assist]

The event name is @updateEComStore, but the handler method is updateProductStore. For consistency, the event emitted from DxpProductStoreSelector should be renamed to @updateProductStore. This would improve the clarity of the component's API.