Fixed:fixes the ui displaying label under chip(#360) #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Sep 17, 2025
ymaheshwari1
requested changes
Oct 14, 2025
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a UI issue where a label was not correctly displayed under its corresponding chip. The fix involves wrapping the ion-chip and ion-note components in a div and applying centering. The changes are straightforward and seem to solve the problem. I've added a couple of suggestions to improve code formatting and ensure the new styles work as intended.
dt2patel
requested changes
Oct 15, 2025
dt2patel
requested changes
Oct 16, 2025
| <ion-label>{{ facility.orderCount }} {{ '/' }} {{ facility.maximumOrderLimit }}</ion-label> | ||
| </ion-chip> | ||
| <ion-note class="config-label">{{ translate('threshold consumed') }}</ion-note> | ||
| <div class="ion-text-center"> |
| <ion-chip outline @click.stop="changeOrderLimitPopover($event, facility)"> | ||
| <ion-label>{{ facility.orderCount }} {{ '/' }} {{ facility.maximumOrderLimit }}</ion-label> | ||
| </ion-chip> | ||
| <ion-note class="config-note"> |
There was a problem hiding this comment.
https://ionicframework.com/docs/layout/css-utilities#display
set display block using utility class. Remove all css for this class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#360
Fixed: showing the chip and label ,displaying the label under the chip in UI
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance