fmtm stepper fix #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Nice, thanks 😃 Could this also be added to the PR here too? (probably good to set the base of this PR to that linked branch, then we can merge in that branch to the |
|
@spwoodcock , sounds good. I'll close this PR and added to the existing branch. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalStep wasn't being recomputed but the number of steps is dynamic, changing based on what was selected in previous steps. For example, if you select that a building exists, additional steps will be added. Without the fix, the "send" button will be shown earlier than expected and not allow you to reach the final steps.
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
I'm working on fmtm, so I've used this new code in fmtm to verify that it works
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed