Skip to content

Improved welcome and server list onboarding #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025
Merged

Improved welcome and server list onboarding #3617

merged 4 commits into from
May 27, 2025

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented May 26, 2025

Summary

Screenshots

onb-2.mp4

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from Copilot May 26, 2025 12:42
@bgoncal bgoncal self-assigned this May 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the onboarding flow by adding new localized strings, refactoring UI components for better state management, and introducing shared safe‐area utilities.

  • Adds localized keys for invitation options and onboarding welcome buttons.
  • Refactors HAProgressView to use an ObservableObject view model and centralizes safe‐area insets into a shared SwiftUI extension.
  • Enhances OnboardingWelcomeView with animation constants and safe‐area handling, and updates OnboardingServersListView to conditionally show header and manual input buttons after discovery delays.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Sources/Shared/Resources/Swiftgen/Strings.swift New Invitation enum and welcome button string properties.
Sources/Shared/DesignSystem/Components/HAProgressView.swift Switched from @State to @StateObject view model for animations.
Sources/App/Utilities/Extensions/SwiftUI+SafeArea.swift Introduced reusable safe‐area insets environment key and extensions.
Sources/App/WebView/Views/WebViewEmptyStateView.swift Removed duplicated safe‐area extensions from this view.
Sources/App/Onboarding/Screens/OnboardingWelcomeView.swift Added animation constants, safe‐area padding, and view modifiers.
Sources/App/Onboarding/Screens/OnboardingServersList/OnboardingServersListView.swift Added delayed header and manual input button state logic.
Files not reviewed (3)
  • HomeAssistant.xcodeproj/project.pbxproj: Language not supported
  • Sources/App/Resources/Base.lproj/LaunchScreen.storyboard: Language not supported
  • Sources/App/Resources/en.lproj/Localizable.strings: Language not supported
Comments suppressed due to low confidence (1)

Sources/Shared/Resources/Swiftgen/Strings.swift:1938

  • [nitpick] The secondaryButton name is generic and may be unclear; consider renaming it to learnMoreButton or learnMore to better reflect that it opens the Learn More/Get Started documentation.
public static var secondaryButton: String { return L10n.tr("Localizable", "onboarding.welcome.secondary_button") }

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (4f60d68) to head (644e32f).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...hared/DesignSystem/Components/HAProgressView.swift 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3617      +/-   ##
==========================================
+ Coverage   44.72%   45.67%   +0.95%     
==========================================
  Files         232      232              
  Lines       13911    13965      +54     
==========================================
+ Hits         6221     6378     +157     
+ Misses       7690     7587     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal merged commit c42ae1d into master May 27, 2025
14 checks passed
@bgoncal bgoncal deleted the onboarding branch May 27, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant