-
Notifications
You must be signed in to change notification settings - Fork 359
Improved welcome and server list onboarding #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the onboarding flow by adding new localized strings, refactoring UI components for better state management, and introducing shared safe‐area utilities.
- Adds localized keys for invitation options and onboarding welcome buttons.
- Refactors
HAProgressView
to use anObservableObject
view model and centralizes safe‐area insets into a shared SwiftUI extension. - Enhances
OnboardingWelcomeView
with animation constants and safe‐area handling, and updatesOnboardingServersListView
to conditionally show header and manual input buttons after discovery delays.
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
Sources/Shared/Resources/Swiftgen/Strings.swift | New Invitation enum and welcome button string properties. |
Sources/Shared/DesignSystem/Components/HAProgressView.swift | Switched from @State to @StateObject view model for animations. |
Sources/App/Utilities/Extensions/SwiftUI+SafeArea.swift | Introduced reusable safe‐area insets environment key and extensions. |
Sources/App/WebView/Views/WebViewEmptyStateView.swift | Removed duplicated safe‐area extensions from this view. |
Sources/App/Onboarding/Screens/OnboardingWelcomeView.swift | Added animation constants, safe‐area padding, and view modifiers. |
Sources/App/Onboarding/Screens/OnboardingServersList/OnboardingServersListView.swift | Added delayed header and manual input button state logic. |
Files not reviewed (3)
- HomeAssistant.xcodeproj/project.pbxproj: Language not supported
- Sources/App/Resources/Base.lproj/LaunchScreen.storyboard: Language not supported
- Sources/App/Resources/en.lproj/Localizable.strings: Language not supported
Comments suppressed due to low confidence (1)
Sources/Shared/Resources/Swiftgen/Strings.swift:1938
- [nitpick] The
secondaryButton
name is generic and may be unclear; consider renaming it tolearnMoreButton
orlearnMore
to better reflect that it opens the Learn More/Get Started documentation.
public static var secondaryButton: String { return L10n.tr("Localizable", "onboarding.welcome.secondary_button") }
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3617 +/- ##
==========================================
+ Coverage 44.72% 45.67% +0.95%
==========================================
Files 232 232
Lines 13911 13965 +54
==========================================
+ Hits 6221 6378 +157
+ Misses 7690 7587 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Screenshots
onb-2.mp4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes