-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add Blueprint Editor #25646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Blueprint Editor #25646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
src/panels/config/blueprint/input/types/ha-blueprint-input-input.ts
Outdated
Show resolved
Hide resolved
"edit_ui": "UI Editor", | ||
"edit_yaml": "YAML Editor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need sentence-casing on these strings and a bunch more below.
"edit_ui": "UI editor",
"edit_yaml": "YAML editor",
"delete_confirm_title": "Delete input",
"change_id": "Change input ID",
"default": "Default value",
"add_description": "Add description",
"add_author": "Add author",
"add_minimum_version": "Add minimum version"
"label": "Minimum version",
I may have missed another one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do! I'll double check all of the ones I added. Is the general guidance to use sentence casing on everything? Or are there any exceptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Home Assistant uses sentence-casing in general. It helps translators like me to see what can be translated and what is a (capitalized) name or abbreviation that we should keep in translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! Thanks for pointing it out. I'll try to get to this some time today
Proposed change
I wanted to add an editor for Blueprints, similar to Automations and Scripts. Essentially, this creates a page that has an editor for
blueprintObject.metadata.input
, then embeds the existing automation/script editor.There was a WTH forum post asking for this. I'm not sure if there were any formal feature requests/roadmap plans, but truthfully this is mostly inspired by my own desire for this feature to exist.
Type of change
Example configuration
I don't think any particular configuration is needed to test this, especially since HA comes with a couple blueprints out of the box.
Additional information
Additionally, I have concerns about the size of this MR. I think it's quite large. If it should be broken up, I'd love to do that. I just need guidance on the best strategy. However, there are parts of this feature I left out explicitly because of the size:
/show
route!input
s in visual selectorsSelector ConfigurationImplemented, thanks to feedback from karwosts!Checklist
test
directory. Let me know if there's something I can look at!If user exposed functionality or configuration variables are added/changed: