-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Add support for aiomysql, aiosqlite and asyncpg #155255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey there @gjohansson-ST, @dougiteixeira, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Please explain in the PR description why you want to make this change. |
| # https://github.com/aio-libs/aiomysql | ||
| "sql": {"homeassistant": {"aiomysql"}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't think it's a good idea to add a requirements exception.
This is used to track "existing" violations, not to enable new violations to come in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do about
Error: R] [REQUIREMENTS] Package aiomysql has a forbidden top level directory 'docs' in homeassistant
during Check hassfest to handle it properly then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should raise an issue on aiomysql repository to ask them to remove the docs from the published package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly linked to tool.setuptools.packages.find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.. okay. I'll do that then, thanks.
6f2b976 to
381c25e
Compare
Signed-off-by: David Rapan <david@rapan.cz>
381c25e to
7676e77
Compare
|
Please stop rebasing unnecessarily, and do NOT merge commits.
|
|
I do it when I want to restart checks, usually. 😉 |
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
Signed-off-by: David Rapan <david@rapan.cz>
e5a0385 to
fd3e8e6
Compare
Signed-off-by: David Rapan <david@rapan.cz>
Proposed change
Add support for aiomysql, aiosqlite and asyncpg drivers to:
*.async_add_executor_job()on HA side:core/homeassistant/components/sql/sensor.py
Lines 248 to 251 in ce5538e
In the form of new async drivers:
mysql+aiomysql://for MariaDB (aiomysql==0.3.2)sqlite+aiosqlite://for SQLite (aiosqlite==0.21.0)postgresql+asyncpg://for PostgreSQL (asyncpg==0.30.0)+ greenlet through SQLAlchemy[asyncio] because asynchronous SQLAlchemy depends on it
And improves code coverage.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: