-
-
Notifications
You must be signed in to change notification settings - Fork 9
- Updated .once and added .oneshot modifier descriptions in the modifiers documentation.
#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…odifiers documentation. - Improved formatting in playground.vue for better readability. - Refactored plugin.ts to ensure proper handling of `.once` and `.oneshot` modifiers, including a warning when both are used together. - General code cleanup and formatting adjustments across multiple files for consistency.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @davidparys, thats awesome, thank you! However, I feel like Tbh I would prefer reversing the logic, reverting What do you think? Can you change your PR according to that? |
- added .reversible to .once - changed the behaviour of .once to really be once as in previous versions
Absolutely! It was a little bit confusing for me why this was changed in 1.1.8 so I thought this was a wanted change and wanted to keep both separate. I've changed |
|
Amazing, thank you so much! I am also impressed how thoughtful you added the everything to the docs 💪 Merging and releasing now |
A pleasure! Sorry about the linting I have everything set to default in Vscode :D |
|
haha no worries :D btw:
This change in |
I felt like the behaviour from the previous version was kinda useful so added I oneshot, it would trigger the animation only once it won't play again when scrolling out/in of view again.
.onceand.oneshotmodifiers, including a warning when both are used together.