Add possibility to remove racer finish time #45
Merged
+48
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holoujak
force-pushed
the
remove-finish-time
branch
from
1ceac6b to
67d7f20
Compare
trnila
reviewed
Oct 16, 2025
| let racer = self.racers.iter_mut().find(|r| predicate(r)).ok_or(())?; | ||
| racer.finish = Some(time); | ||
|
|
||
| if racer.finish.is_some() && time.is_some() { |
There was a problem hiding this comment.
will it allow changing time manually?
| racer.finish = time; | ||
| racer.time = calculate_time(racer.start, racer.finish); | ||
|
|
||
| if racer.finish.is_none() { |
There was a problem hiding this comment.
should be written to the log as well
There was a problem hiding this comment.
It is... Execution will continue to log_finish function.
trnila
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.