Add result printer #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holoujak
force-pushed
the
print-results
branch
6 times, most recently
from
49b8589 to
c9d7bb7
Compare
trnila
reviewed
Oct 14, 2025
src/printer.rs
Outdated
| use genpdf::Element as _; | ||
| use genpdf::{elements, fonts, style}; | ||
|
|
||
| const FONT_DIRS: &[&str] = &["/usr/share/fonts/truetype/ubuntu"]; |
There was a problem hiding this comment.
can we add these fonts to our app? Its crashing now for me as fonts are not found.
src/components/app.rs
Outdated
|
|
||
| rsx! { | ||
| if printed() { | ||
| div { |
There was a problem hiding this comment.
what about running xdg-open generated.pdf instead?
src/components/app.rs
Outdated
| class: "btn btn-primary", | ||
| onclick: move |_| { | ||
| info!("Printing results for race {}", race.id); | ||
| print_result(&race.clone()); |
src/printer.rs
Outdated
| use genpdf::Element as _; | ||
| use genpdf::{elements, fonts, style}; | ||
|
|
||
| const FONT_DIRS: &[&str] = &["/usr/share/fonts/truetype/ubuntu"]; |
There was a problem hiding this comment.
does it need to be an list then?
src/printer.rs
Outdated
| print_categories(&mut doc, race); | ||
|
|
||
| doc.render_to_file(output_file) | ||
| .expect("Failed to write output file"); |
There was a problem hiding this comment.
i would rather log/return error? ... crashing is not nice (?)
holoujak
force-pushed
the
print-results
branch
from
c9d7bb7 to
09b81cc
Compare
holoujak
force-pushed
the
print-results
branch
from
09b81cc to
1375d37
Compare
trnila
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.