Filter fields #25
Merged
Filter fields #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trnila
reviewed
Oct 9, 2025
src/sort_table.rs
Outdated
| pub sorter: Signal<Sorter<F>>, | ||
| pub field: F, | ||
| #[props(optional)] | ||
| pub filter: Option<Signal<Option<String>>>, |
There was a problem hiding this comment.
because it could be undefined, not sure if there is any other possibility to define that :-|
There was a problem hiding this comment.
why its undefined? Empty hashmap should be fine?
holoujak
force-pushed
the
filter-fields
branch
3 times, most recently
from
1e3fafe to
c4babd9
Compare
holoujak
force-pushed
the
filter-fields
branch
2 times, most recently
from
d6bb579 to
582ae88
Compare
trnila
approved these changes
Oct 13, 2025
src/components/racers.rs
Outdated
| category: Option<Category>, | ||
| ) -> bool { | ||
| if let Some(cat) = category { | ||
| if !racer.categories.iter().any(|c| c == &cat) { |
src/sort_table.rs
Outdated
| pub sorter: Signal<Sorter<F>>, | ||
| pub field: F, | ||
| #[props(optional)] | ||
| pub filter: Option<Signal<Option<String>>>, |
There was a problem hiding this comment.
why its undefined? Empty hashmap should be fine?
| th { role: "button", | ||
| span { | ||
| onclick: move |_| { | ||
| sorter.write().toggle(field); |
There was a problem hiding this comment.
it is :), at least signal is not updated without it :)
holoujak
force-pushed
the
filter-fields
branch
from
582ae88 to
d68891a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.