Skip to content

feat: fetch a role in an organisation endpoint #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sparkybug
Copy link
Contributor

@sparkybug sparkybug commented Aug 8, 2024

Description

Develop an API endpoint to fetch a specific role within an organisation.

Related Issue (Link to Github issue)

#418

Motivation and Context

Enable users to fetch a specific role within an organisation.

How Has This Been Tested?

Unit Tests:

  • Successful response with valid organisation ID and role ID.
  • Invalid organisation ID format.
  • Invalid role ID format.
  • Non-existent organisation ID.
  • Non-existent role ID.
  • Internal server error.

Screenshots (if appropriate - Postman, etc):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparkybug sparkybug changed the title Feat/fetch a role in an organisation endpoint [Feat] Fetch a role in an organisation endpoint Aug 8, 2024
@sparkybug sparkybug changed the title [Feat] Fetch a role in an organisation endpoint feat: Fetch a role in an organisation endpoint Aug 8, 2024
@sparkybug sparkybug changed the title feat: Fetch a role in an organisation endpoint feat: fetch a role in an organisation endpoint Aug 8, 2024
@timiajayi
Copy link
Contributor

need additional approval

@sparkybug
Copy link
Contributor Author

need additional approval

@Dev-Tonia please help approve this. God bless you!

Copy link

gitguardian bot commented Aug 8, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13348460 Triggered Generic High Entropy Secret 20560c6 .env.example View secret
13348460 Triggered Generic High Entropy Secret 7c37feb .env.example View secret
13348443 Triggered Generic High Entropy Secret 7e6c24b tests/Unit/RegistrationTest.php View secret
13348443 Triggered Generic High Entropy Secret 7e6c24b tests/Unit/RegistrationTest.php View secret
13348443 Triggered Generic High Entropy Secret 20560c6 tests/Unit/RegistrationTest.php View secret
13348443 Triggered Generic High Entropy Secret 20560c6 tests/Unit/RegistrationTest.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@timiajayi
Copy link
Contributor

failing test

@timiajayi
Copy link
Contributor

Merge conflict

1 similar comment
@timiajayi
Copy link
Contributor

Merge conflict

@sparkybug
Copy link
Contributor Author

Merge conflict

I have fixed this boss.

@timiajayi timiajayi merged commit 90f7e2b into hngprojects:dev Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants