Skip to content

fix: include nakamoto coinbase txs on coinbase txs filter #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

fix: include nakamoto coinbase txs on coinbase txs filter #2339

merged 4 commits into from
Aug 19, 2025

Conversation

@ASuciuX
Copy link
Collaborator

@ASuciuX ASuciuX commented Aug 14, 2025 •
edited
Loading

For details refer to issue #2323

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No.

Are documentation updates required?

No.

Testing information

Provide context on how tests should be performed.
Steps to reproduce the bug are on the issue referenced.

docker compose -f docker/docker-compose.dev.postgres.yml up -d
npm run test -- --config ./tests/jest.config.api.js tests/api/tx.test.ts -t "tx list - filter by tx-type" --runInBand

@ASuciuX ASuciuX requested a review from rafaelcr August 14, 2025 14:22
@codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

github-actions bot commented Aug 14, 2025 •
edited
Loading

Vercel deployment URL: https://stacks-blockchain-hg5pn3ns8-hirosystems.vercel.app 🚀

rafaelcr
rafaelcr reviewed Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Can you add a unit test for this? You can take a test that exercises the filter and just add a nakamoto coinbase tx to it to make sure it works

rafaelcr
rafaelcr reviewed Aug 18, 2025
View reviewed changes
@ASuciuX ASuciuX requested a review from rafaelcr August 19, 2025 15:40
rafaelcr
rafaelcr approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ASuciuX !

@rafaelcr rafaelcr merged commit c9ef5e8 into develop Aug 19, 2025
26 checks passed
@rafaelcr rafaelcr deleted the fix/coinbase-txs-filter branch August 19, 2025 16:13
hirosystems-release-bot bot added a commit that referenced this pull request Aug 26, 2025
@hirosystems-release-bot
chore(release): 8.12.1 [skip ci]
e1c1406 
## [8.12.1](v8.12.0...v8.12.1) (2025-08-26)

### Bug Fixes

* include nakamoto coinbase txs on coinbase txs filter ([#2339](#2339)) ([c9ef5e8](c9ef5e8))
* pox cycle signer stackers query pagination ([#2345](#2345)) ([1353554](1353554))
@hirosystems-release-bot
Copy link
Contributor

🎉 This PR is included in version 8.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ASuciuX @rafaelcr