Release v2.9.0

[araffin]

Description

This is the (Christmas) v2.9.0 release.

Motivation and Context

• I have raised an issue to propose this change (required for new features and bug fixes)

I also updated the documentation and docstrings at some places:

• addresses part of The output of the making a gif example is wrong. #625
• closes Structure of ReplayBuffer._storage #610
• closes Weird tensorboard plots in GAIL #577
• closes assert self.n_batch % self.nminibatches == 0 AssertionError #537

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (update in the documentation)

Checklist:

• I've read the CONTRIBUTION guide (required)
• I have updated the changelog accordingly (required).
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.
• I have ensured pytest and pytype both pass.

[AdamGleave]

Are we dropping support for 3.5? If so we should specify the lowest supported version here. We should probably also add a python_requires in setup.py

[araffin]

Is there a way to allow using pytype with python > 3.5?
I removed this line because I had to comment it each time I wanted to check typing, which was quite annoying.
If there is no other mean, I'll put that line back.

[araffin]

so, no drop of python 3.5 support yet (I would have created an issue if this was the case)

[AdamGleave]

I think pytype always type checks with the Python version of the interpreter it's running under, which is a bit annoying. If you don't specify it then it'll use the system default. It seems unfortunate to get different type check results depending on what system you're running on, but uncommenting the line does sound frustrating.

Could you install Python 3.5 in addition to the Python interpreter you normally use?

[araffin]

I can but this would mean duplicating a complete conda env only for this particular purpose.
i'll put the line back

[AdamGleave]

LGTM