Skip to content

feat: edit rpc_relay_consensusnode_* metrics #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Jun 25, 2025

Description:

Recently, we audited all metrics (private page due to security reasons) and how they can be improved more efficiently. In this PR, we remove some of the rpc_relay_consensusnode_* labels.

Related issue(s):

Fixes #3853

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow requested review from a team as code owners June 25, 2025 09:15
@natanasow natanasow requested a review from acuarica June 25, 2025 09:15
@natanasow natanasow self-assigned this Jun 25, 2025
@natanasow natanasow added the enhancement New feature or request label Jun 25, 2025
@natanasow natanasow added this to the 0.70.0 milestone Jun 25, 2025
Copy link

github-actions bot commented Jun 25, 2025

Test Results

 20 files  ±0  256 suites  ±0   18m 11s ⏱️ +4s
666 tests ±0  661 ✅ ±0  5 💤 ±0  0 ❌ ±0 
682 runs  ±0  677 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 30cdca6. ± Comparison against base commit 928f5c7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove interactingEntity (and maybe callerName) from IExecuteQueryEventPayload altogether? If these properties are indeed not used anymore, removing them would allow us to reduce future tech debt.

Signed-off-by: nikolay <n.atanasow94@gmail.com>
acuarica
acuarica previously approved these changes Jun 25, 2025
konstantinabl
konstantinabl previously approved these changes Jun 25, 2025
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow dismissed stale reviews from konstantinabl and acuarica via 30cdca6 June 25, 2025 13:56
@natanasow natanasow requested a review from acuarica June 25, 2025 14:00
@natanasow natanasow merged commit edd6c18 into main Jun 26, 2025
141 of 144 checks passed
@natanasow natanasow deleted the 3853-fix-consensus-metrics branch June 26, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and Refactor Metrics to Avoid High Cardinality from Unique Labels
4 participants