fix: fixes caching for nested objects and adds tests #3873
+106
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…en-added-to-cache-key
…en-added-to-cache-key
acuarica
reviewed
Jun 24, 2025
There was a problem hiding this comment.
We can improve the type of generateCacheKey by using unknown
const generateCacheKey = (methodName: string, args: IArgument[]) => {const generateCacheKey = (methodName: string, args: unknown[]) => {Please note that this is not strictly about the issue mentioned in the PR. However, given that in the tests (see below) we type casting to use this function, maybe we can change it here.
Also, we can change the outer loop from
for (const [, value] of Object.entries(args)) {to
for (const value of args) {right?
| @@ -208,21 +208,21 @@ describe('cache decorator', () => { | |||
|
|
|||
| describe('generateCacheKey', () => { | |||
| it('should return only the method name when args are empty', () => { | |||
| const args = [] as unknown as IArguments; | |||
| const args = [] as unknown as IArguments[]; | |||
There was a problem hiding this comment.
If we apply the suggestion left in cache.decorator.ts comment, we can avoid this casts.
| @@ -123,7 +123,9 @@ const generateCacheKey = (methodName: string, args: IArgument[]) => { | |||
| if (value?.constructor?.name != 'RequestDetails') { | |||
| if (value && typeof value === 'object') { | |||
| for (const [key, innerValue] of Object.entries(value)) { | |||
There was a problem hiding this comment.
So, now that we are using JSON.stringify, this loop might not be needed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated the generateCacheKey function to properly serialize nested objects using JSON.stringify()
Related issue(s):
Fixes #3872
Testing