feat: adds Forwarded header to downstream MN requests + custom parsing for Forwarded headers #3871
+391
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for Forwarded Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Test Results 21 files - 1 278 suites - 22 20m 4s ⏱️ - 1m 25s For more details on these failures, see this check. Results for commit d9e138b. ± Comparison against base commit b0c8b67. ♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
acuarica
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With app.proxy enabled, we already parse X-Forwarded-For headers correctly. Custom parsing for Forwarded headers has been added, along with passing a Forwarded header with the original client IP to the mirror node (if present). All of this was included in the tests coverage
Related issue(s):
Fixes #3772