Skip to content

feat: introduce OPCODELOGGER_ENABLED configuration flag to enable/disable opcodeLogger tracer #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Jun 21, 2025

Description:

This PR introduces the OPCODELOGGER_ENABLED to enable/disable the opcodeLogger tracer.

Related issue(s):

Fixes #3868.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica added this to the 0.70.0 milestone Jun 21, 2025
@acuarica acuarica self-assigned this Jun 21, 2025
@acuarica acuarica added the enhancement New feature or request label Jun 21, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jun 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

github-actions bot commented Jun 21, 2025

Test Results

 22 files  +  2  305 suites  +49   18m 54s ⏱️ +47s
668 tests +  2  661 ✅ ±  0  5 💤 ±0  2 ❌ +2 
884 runs  +202  877 ✅ +200  5 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit ff0dd5b. ± Comparison against base commit 928f5c7.

♻️ This comment has been updated with latest results.

@@ -34,7 +34,6 @@ let restMock: MockAdapter;
let web3Mock: MockAdapter;
let mirrorNodeInstance: MirrorNodeClient;
let debugService: DebugImpl;
let hapiServiceInstance: HAPIService;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: this variables was unused, so I removed it.

acuarica added 3 commits June 25, 2025 01:27
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica force-pushed the 3868-flag-to-enabledisable-opcodelogger branch from b151d81 to ff0dd5b Compare June 24, 2025 23:27
@acuarica acuarica marked this pull request as ready for review June 24, 2025 23:28
@acuarica acuarica requested review from a team as code owners June 24, 2025 23:28
@acuarica acuarica requested a review from simzzz June 24, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a configuration flag to enable/disable opcodeLogger in debug_traceTransaction
2 participants