Skip to content

feat: add MAX_GAS_ALLOWANCE_HBAR configuration #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Jun 18, 2025

Description:

Some providers need to fully subsidise their users' transactions. This option is already available on the network and in the SDK by setting the max_gas_allowance parameter accordingly.

This PR enables this parameter to be set via the JSON-RPC Relay configuration as well.

Related issue(s):

N/A

Notes for reviewer:

Now both the brand new MAX_GAS_ALLOWANCE_HBAR and the existing GAS_PRICE_TINY_BAR_BUFFER env variables are loaded dynamically via ConfigService.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Neurone Neurone requested review from a team as code owners June 18, 2025 22:30
@Neurone Neurone requested a review from konstantinabl June 18, 2025 22:30
@lfdt-bot
Copy link

lfdt-bot commented Jun 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@Neurone Neurone changed the title feat: add MAX_GAS_ALLOWANCE_HBAR configuration [DRAFT] feat: add MAX_GAS_ALLOWANCE_HBAR configuration Jun 18, 2025
…ctionality

Signed-off-by: Giuseppe Bertone <giuseppe.bertone@hashgraph.com>
@Neurone Neurone force-pushed the feature-add-maxGasAllowance branch from dbc4925 to 6039a8e Compare June 19, 2025 00:01
@Neurone Neurone changed the title [DRAFT] feat: add MAX_GAS_ALLOWANCE_HBAR configuration feat: add MAX_GAS_ALLOWANCE_HBAR configuration Jun 19, 2025
@quiet-node quiet-node added the enhancement New feature or request label Jun 20, 2025
@quiet-node quiet-node added this to the 0.70.0 milestone Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants