Return 32-byte block hash from eth_getFilterChanges to ensure EVM compatibility #3863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure
eth_getFilterChanges
returns a 32-byte block hash to match Ethereum's expectations.eth_getBlockByHash
Notes for reviewer:
Previously,
eth_getFilterChanges
returned 48-byte block hashes, causingeth_getBlockByHash
to fail with a parameter validation error. This PR ensures that only the first 32 bytes are returned, complying with Ethereum's JSON-RPC spec.Example of uncorrected output response:
Example of corrected output response:
Checklist