Skip to content

feat: edit rpc_relay_eth_executions and rpc_websocket_connection_duration_seconds_bucket metrics #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Jun 17, 2025

Description:

Currently, we have increased cost of the Grafana due to several unique IDs labels that are populated in Prometheus.

Solution:

  • remove from, to, and function from rpc_relay_eth_executions
  • remove the label from rpc_websocket_connection_duration_seconds_bucket

Related issue(s):

Fixes #3853

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow requested review from a team as code owners June 17, 2025 11:18
@natanasow natanasow requested a review from acuarica June 17, 2025 11:18
@lfdt-bot
Copy link

lfdt-bot commented Jun 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@natanasow natanasow self-assigned this Jun 17, 2025
@natanasow natanasow added the enhancement New feature or request label Jun 17, 2025
@natanasow natanasow added this to the 0.69.0 milestone Jun 17, 2025
Copy link

github-actions bot commented Jun 17, 2025

Test Results

 20 files  ±0  256 suites  ±0   18m 18s ⏱️ +8s
665 tests ±0  660 ✅ ±0  5 💤 ±0  0 ❌ ±0 
681 runs  ±0  676 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 84c26bb. ± Comparison against base commit d4229d9.

♻️ This comment has been updated with latest results.

Copy link

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow requested a review from a team June 17, 2025 12:26
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@natanasow natanasow merged commit 43136cd into main Jun 17, 2025
51 of 52 checks passed
@natanasow natanasow deleted the 3853-refactor-relay-executions-and-websocket-connection-duration-metrics branch June 17, 2025 13:22
natanasow added a commit that referenced this pull request Jun 17, 2025
…uration_seconds_bucket` metrics (#3860)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
mwb-al pushed a commit to mwb-al/hiero-json-rpc-relay that referenced this pull request Jun 23, 2025
…uration_seconds_bucket` metrics (hiero-ledger#3860)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and Refactor Metrics to Avoid High Cardinality from Unique Labels
5 participants