feat: update getBalance method to require blockNumberOrTagOrHash parameter instead of allowing null (#3838)
#3859
+14
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter instead of allowing null (hiero-ledger#3838) Signed-off-by: Michał Walczak <michal.walczak@arianelabs.com>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
quiet-node
approved these changes
Jun 20, 2025
| @@ -91,12 +91,12 @@ export class AccountService implements IAccountService { | |||
| * Current implementation does not yet utilize blockNumber | |||
| * | |||
| * @param {string} account The account to get the balance from | |||
| * @param {string | null} blockNumberOrTagOrHash The block number or tag or hash to get the balance from | |||
| * @param {string} blockNumberOrTagOrHash The block number or tag or hash to get the balance from | |||
There was a problem hiding this comment.
I thibk we should a test to enforce required. Somethin like cannot be bull, blockNumberOrTagOrHashIsRequired
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #3859 +/- ##
=======================================
Coverage ? 41.29%
=======================================
Files ? 83
Lines ? 4770
Branches ? 970
=======================================
Hits ? 1970
Misses ? 2536
Partials ? 264
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated
getBalancemethod and related tests to accommodate parameter type change fromstring | nulltostring.Related issue(s):
Fixes #3838
Checklist